Skip to content

Confirm usage-limit resets before redemption - #33845

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/828945f99f06e8c73941fd864e4aa9ac52729f98
Jul 17, 2026
Merged

Confirm usage-limit resets before redemption#33845
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/828945f99f06e8c73941fd864e4aa9ac52729f98

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 17, 2026

Copy link
Copy Markdown

Confirm usage-limit resets before redemption

Why

Selecting a usage-limit reset from the picker immediately started redemption,
leaving no opportunity to verify the choice.

What changed

  • Open a separate confirmation popup before redeeming a selected reset, with
    No, go back selected by default.
  • Show backend-provided reset titles and descriptions in the picker and
    confirmation, with generic fallback copy when those details are absent.
  • Ignore duplicate or stale confirmation and redemption events, while retaining
    the idempotency key needed to retry a failed redemption.

Testing

  • Added coverage for confirmation, cancellation, backend copy, duplicate and
    stale events, successful redemption, and retry behavior.

## Why

Selecting a usage-limit reset from the picker immediately started redemption,
leaving no opportunity to verify the choice.

## What changed

- Open a separate confirmation popup before redeeming a selected reset, with
  `No, go back` selected by default.
- Show backend-provided reset titles and descriptions in the picker and
  confirmation, with generic fallback copy when those details are absent.
- Ignore duplicate or stale confirmation and redemption events, while retaining
  the idempotency key needed to retry a failed redemption.

## Testing

- Added coverage for confirmation, cancellation, backend copy, duplicate and
  stale events, successful redemption, and retry behavior.

GitOrigin-RevId: 828945f99f06e8c73941fd864e4aa9ac52729f98
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/828945f99f06e8c73941fd864e4aa9ac52729f98 branch from 70279a5 to a50e822 Compare July 17, 2026 15:29
@copyberry
copyberry Bot merged commit a50e822 into main Jul 17, 2026
23 of 41 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/828945f99f06e8c73941fd864e4aa9ac52729f98 branch July 17, 2026 15:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants